Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Startup diagnostic serialization fails when diagnostic entries include System.Type properties #6829

Merged
merged 1 commit into from
Sep 1, 2023
Merged

Startup diagnostic serialization fails when diagnostic entries include System.Type properties #6829

merged 1 commit into from
Sep 1, 2023

Conversation

danielmarbach
Copy link
Contributor

@danielmarbach danielmarbach commented Sep 1, 2023 •
edited by ramonsmits
Loading

@danielmarbach danielmarbach changed the base branch from master to release-8.1 September 1, 2023 06:34
@danielmarbach danielmarbach changed the title Diagnostics serialization support for types Startup diagnostic serialization fails when diagnostic entries include System.Type properties Sep 1, 2023
@danielmarbach danielmarbach added this to the 8.1.2 milestone Sep 1, 2023
@danielmarbach danielmarbach marked this pull request as ready for review September 1, 2023 06:34
timbussmann
timbussmann approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@timbussmann timbussmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ideally we just would just update callers of the API but this seems sensible to avoid issues when users would only update the NSB packages without the patched downstream instead.

@danielmarbach danielmarbach merged commit 267c25a into release-8.1 Sep 1, 2023
2 checks passed
@danielmarbach danielmarbach deleted the diagnostics-serialization branch September 1, 2023 14:43
@danielmarbach danielmarbach mentioned this pull request Sep 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasohlund andreasohlund andreasohlund approved these changes

@DavidBoike DavidBoike DavidBoike approved these changes

@timbussmann timbussmann timbussmann approved these changes

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
8.1.2
Development

Successfully merging this pull request may close these issues.

Startup diagnostic serialization fails when diagnostic entries include System.Type properties
4 participants
@danielmarbach @andreasohlund @DavidBoike @timbussmann