Start a new trace (or root activity) for delayed messages #7049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ptions or delayed retry
…nceTestingTransport to enable native delayed delivery in the tests that require it
ramonsmits
reviewed
May 31, 2024
ramonsmits
reviewed
May 31, 2024
ramonsmits
reviewed
May 31, 2024
|
@ramonsmits addressed your comments |
lailabougria
force-pushed
the
new-trace-for-delayed-msgs
branch
from
40b29ae
to
f23b1f3
Compare
lailabougria
commented
Jun 3, 2024
lailabougria
commented
Jun 3, 2024
…de simpler and less vulnerable to side effects
…moved to the error queue
SzymonPobiega
approved these changes
Jun 3, 2024
SzymonPobiega
approved these changes
Jun 3, 2024
This was referenced Jun 17, 2024
SzymonPobiega
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
This change ensures that anytime a message is delayed, we ensure to start a new root activity and never create a child span.
Delayed messages can occur when:
This is important for tail-sampling scenarios in which a sampling decision is at a point in time, so we want to avoid any delayed operations to be in there.
Documentation: https://docs.particular.net/nservicebus/operations/opentelemetry#traces-delayed-messages