Ensure that the TTBR tests do not end just after the feature startup is done #7062
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
poornimanayar
approved these changes
Jun 12, 2024
tmasternak
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptoms
Acceptance tests for TTBR always pass.
Who's affected
None of the users are affected.
Downstream components maintained by Particular using the tests.
Root cause
Acceptance tests for TTBR do not specify
Donecondition and use the defaultDonecondition i.e.() => true. This causes the test to end immediately, just after theOnStartmethod ofFeatureStartupTaskfinishes.As a result, the tests that check if messages with TTBR are not delivered when the expiry time elapses finish with false positive results.