Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssemblyScanner doesn't scan message assemblies that reference Message Interfaces #7091

Merged
merged 3 commits into from
Jul 2, 2024

Commits on Jul 1, 2024

  1. AssemblyScanner doesn't scan message assemblies that reference Messag…

    …e Interfaces (#7081)
    
    * Add a test to verify the messages referencing core are scanned
    
    * Failing test for messages that reference message interfaces
    
    * Unify in one test due avoid assembly loading issues
    
    * Cleanup
    
    * AssemblyScanner should scan assemblies that reference the message interfaces assembly to make sure messages using those interfaces can be discovered and do not act like unobtrusive messages
    
    * Extract into method with a huge comment and inline hints
    
    * Add a type forwarding test as a safety net
    
    * Update src/NServiceBus.Core.Tests/AssemblyScanner/When_using_type_forwarding.cs
    
    Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>
    
    * Apply suggestions from code review
    
    Co-authored-by: Brandon Ording <bording@gmail.com>
    
    * string.Equals
    
    Co-authored-by: Brandon Ording <bording@gmail.com>
    
    ---------
    
    Co-authored-by: danielmarbach <danielmarbach@users.noreply.github.com>
    Co-authored-by: Phil Bastian <155411597+PhilBastian@users.noreply.github.com>
    Co-authored-by: Brandon Ording <bording@gmail.com>
    (cherry picked from commit 3a7c74c)
    danielmarbach committed Jul 1, 2024
    Configuration menu
    Copy the full SHA
    0e98ef8 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c4b1c47 View commit details
    Browse the repository at this point in the history

Commits on Jul 2, 2024

  1. Configuration menu
    Copy the full SHA
    f0d56c5 View commit details
    Browse the repository at this point in the history