Fix ref struct scan for sagas #7187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreasohlund
commented
Oct 23, 2024
...ests/Core/Conventions/When_scanning_an_assembly_containing_a_ref_struct_and_sagas_enabled.cs
Show resolved
Hide resolved
andreasohlund
requested review from
poornimanayar,
mikeminutillo and
lailabougria
SimonCropp
reviewed
Oct 23, 2024
mikeminutillo
approved these changes
Oct 24, 2024
...ests/Core/Conventions/When_scanning_an_assembly_containing_a_ref_struct_and_sagas_enabled.cs
Show resolved
Hide resolved
poornimanayar
pushed a commit
that referenced
this pull request
Oct 25, 2024
* Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
poornimanayar
added a commit
that referenced
this pull request
Oct 25, 2024
andreasohlund
added a commit
that referenced
this pull request
Oct 28, 2024
* Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
andreasohlund
added a commit
that referenced
this pull request
Oct 28, 2024
* Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
andreasohlund
added a commit
that referenced
this pull request
Oct 28, 2024
* Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
andreasohlund
added a commit
that referenced
this pull request
Oct 28, 2024
* Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
andreasohlund
added a commit
that referenced
this pull request
Oct 29, 2024
…gas are present (#7195) * Fix ref struct scan for sagas (#7187) * Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net> * Handle netframework * Use fx agnostic way --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net>
andreasohlund
added a commit
that referenced
this pull request
Oct 29, 2024
andreasohlund
added a commit
that referenced
this pull request
Oct 29, 2024
andreasohlund
added a commit
that referenced
this pull request
Oct 29, 2024
…gas are present (#7196) * Fix ref struct scan for sagas (#7187) * Prevent saga conventions from throwing on ref struct * Better test * Tweaks --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net> * Handle .net framework * Workaround for missing strongly typed check * Update src/NServiceBus.Core/Sagas/Sagas.cs Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net> * Use string equals * Avoid null check --------- Co-authored-by: Mike Minutillo <mike.minutillo@particular.net> Co-authored-by: Daniel Marbach <daniel.marbach@openplace.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7179