[Backport to 5.5] Update Monitoring to support ingesting batched metrics messages with no errors (#4340) #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…no errors (#4340) * Add a test that verifies that Monitoring can ingest batched metrics messages with no errors * Try to make the test fail in a reliable manner * Update NServiceBus dependency to 9.1.1
jpalac
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symptoms
The ServiceControl.Monitoring instance fails to ingest metrics messages and moves them to the error queue. The error shown for the failed messages is the following:
Who's affected
Everyone using ServiceControl.Monitoring V5.5 and having endpoints sending Metrics data to ServiceControl.
Root cause
NServiceBus.Metrics.ServiceControl sends multiple metric messages in a single physical message or payload. This causes an issue when ServiceControl Monitoring tries to consume them with NServiceBus 9.1.0.
This PR adds a test to avoid a regression and upgrades ServiceControl to use NServiceBus 9.1.1.
Backport to release-5.5 of:
Related to: