-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Google Takeout file Download Fixes #77 #315
Conversation
We need to review this to determine if it's required for the v1.0 release. @popofibo - do you know if iOS export is fundamentally broken without this change? |
iOS import with react native webview is definitely broken w/o this change; I referenced to the link in my comment above of the PR to core react native webview package that fixes it more gracefully. The core webview change essentially adds an optional callback |
cc: @kenpugsley @tremblerz if this is to be merged before it starts to conflict |
Leaving this PR, but moving to "next next" the version right after v1.0. Since final translations are already underway, I think the best plan is to merge this in to develop right after the rc-1.0 branch is created. That will put this functionality into the first update after v1.0. |
This will be superseded by #410 as we will remove the webview. |
Fixes #77
This existing react-native-webview bug will be auto-fixed in their next release with this PR. This fix will be a workaround to handle file downloads for iOS by:
Tested on iOS and Android