Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ja and fil languages #700

Merged
merged 1 commit into from
Apr 28, 2020
Merged

Add ja and fil languages #700

merged 1 commit into from
Apr 28, 2020

Conversation

tstirrat
Copy link
Contributor

  • Adds Japanese and Filipino which were exported from Lokalise.
  • Exports the display name to be managed in lokalise.

Linked issues:

NA

Screenshots:

Screen Shot 2020-04-27 at 6 00 29 PM

How to test

efalkner
efalkner approved these changes Apr 28, 2020
View reviewed changes
Copy link
Collaborator

@efalkner efalkner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lo parece bien 👍

@tstirrat tstirrat merged commit aa101e3 into develop Apr 28, 2020
@tstirrat tstirrat deleted the ts-more-languages branch April 28, 2020 01:21
tstirrat added a commit that referenced this pull request Apr 30, 2020
@tstirrat
Merge branch 'develop' into ts-feature-flags
ea6557a 
* develop: (22 commits)
  Translation refresh (#708)
  updated issue template (#729)
  Set up location after skiping the steps (#721)
  App shows green icon when tracking is inactive (#722)
  Fix postinstall script on Windows (#720)
  Fix isVersionGreater and add tests (#726)
  update the upgrade version to 1.0.0, to match what is in the master branch and avoid mistaken forced upgrades. (#723)
  1.0.1 (#715)
  Put GPS filter behind dev flag (#714)
  Fix headline1 text cutoff (#712)
  Put auto sub behind dev flags (#711)
  remove default news url from News.js constructor (#704)
  Fix i18n placeholder for authorities (#709)
  Remove react-native-maps (#695)
  Fix e2e authority auto sub tests (#706)
  Fallback to English translations in e2e tests (#697)
  Add ja and fil languages (#700)
  Add a script to pull translations from lokalise (#641)
  Really really push to lokalise (#699)
  Run lokalize push on merge into develop (#698)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efalkner efalkner efalkner approved these changes

@alpita-masurkar alpita-masurkar Awaiting requested review from alpita-masurkar

@kenpugsley kenpugsley Awaiting requested review from kenpugsley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tstirrat @efalkner