Skip to content

Commit

Permalink
Fix Hateforge Rage cost calculation (#8176)
Browse files Browse the repository at this point in the history
Hateforge was counting skill gem multipliers in the rage cost calculation when it only cares about the soul cost of the skill

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
  • Loading branch information
LocalIdentity and LocalIdentity authored Aug 14, 2024
1 parent 827ca3b commit 7e52bfa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
5 changes: 3 additions & 2 deletions src/Modules/CalcOffence.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1622,9 +1622,10 @@ function calcs.offence(env, actor, activeSkill)
end
elseif val.type == "Rage" then
if skillModList:Flag(skillCfg, "CostRageInsteadOfSouls") then -- Hateforge
val.baseCost = val.baseCost + costs.Soul.baseCost
val.baseCost = costs.Soul.baseCost
val.baseCostNoMult = val.baseCostNoMult + costs.Soul.baseCostNoMult
val.finalBaseCost = val.finalBaseCost + costs.Soul.finalBaseCost
val.finalBaseCost = costs.Soul.baseCost
mult = 1
costs.Soul.baseCost = 0
costs.Soul.baseCostNoMult = 0
costs.Soul.finalBaseCost = 0
Expand Down
1 change: 1 addition & 0 deletions src/Modules/ModParser.lua
Original file line number Diff line number Diff line change
Expand Up @@ -2063,6 +2063,7 @@ local specialModList = {
["vaal skills used during effect have (%d+)%% reduced soul gain prevention duration"] = function(num) return { mod("SoulGainPreventionDuration", "INC", -num, { type = "Condition", var = "UsingFlask" }, { type = "SkillType", skillType = SkillType.Vaal }) } end,
["vaal volcanic fissure and vaal molten strike have (%d+)%% reduced soul gain prevention duration"] = function(num) return { mod("SoulGainPreventionDuration", "INC", -num, { type = "SkillName", skillNameList = { "Volcanic Fissure", "Molten Strike" }, includeTransfigured = true }, { type = "SkillType", skillType = SkillType.Vaal }) } end,
["vaal attack skills cost rage instead of requiring souls to use"] = { flag("CostRageInsteadOfSouls", nil, ModFlag.Attack, { type = "SkillType", skillType = SkillType.Vaal }) },
["vaal attack skills you use yourself cost rage instead of requiring souls"] = { flag("CostRageInsteadOfSouls", nil, ModFlag.Attack, { type = "SkillType", skillType = SkillType.Vaal }) },
["you cannot gain rage during soul gain prevention"] = { mod("RageRegen", "MORE", -100, { type = "Condition", var = "SoulGainPrevention" }) },
["hits that deal elemental damage remove exposure to those elements and inflict exposure to other elements exposure inflicted this way applies (%-%d+)%% to resistances"] = function(num) return {
flag("ElementalEquilibrium"),
Expand Down

0 comments on commit 7e52bfa

Please sign in to comment.