-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tree comparison #2151
Added tree comparison #2151
Conversation
This is a great first PR, very useful feature. Would like to see a few changes though:
|
Ok. So, I updated the commit, squashed it all down, we're now all nice and happy in a single commit. Hiding the dropdown was a little more complicated than the node power version. The node power version has the advantage of being able to just hide everything anchored to it. In my case, that couldn't be done like that, so I had to do some things (See code block at 221ca7f#diff-5fcc1cbe087d23273aa0779a6e056d56b04c07acef5ce3f943b9cd402048353fR74). Hopefully that's how it's meant to be done rather than just some hack. |
Please no unrelated changes to the formatting. This makes it harder to review than necesary. |
I get this error in the Items tab when hovering over a socketed jewel. Using the pastebin that @Quotae posted, even with the tree comparison off. |
Didn't even realize that the jewel's tree position was drawn on jewel hover. Just a method call that didn't match the new signature. Fixed that now too :D |
Oh! Then I'm guessing...yep, this error appears in the Calcs tab, too. Basically on any stat that has I'd run a file search for the method you changed, in case there are other places I can't think of right now |
Okay. So when you pointed out another place, I did indeed do a full source search. Found the one for the calcs tab with my search, and that seems to be the only one left. And that one method was the only one that wasn't a function defined within a local scope of somewhere, so it should be the only breakpoint for the same incorrect method arguments call issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality works great, I finally got a chance to look at the code itself and made some suggestions. Once those are addressed this looks good to go!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adding tree comparison
Relates to #2141
Realized it was just LUA, so it wasn't a huge deal to just throw my hat in the ring for a minute.