Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Added area baseflag to Chain-Hook #2249

Merged
merged 5 commits into from
Mar 3, 2021
Merged

Fix: Added area baseflag to Chain-Hook #2249

merged 5 commits into from
Mar 3, 2021

Conversation

pundm
Copy link
Contributor

@pundm pundm commented Feb 23, 2021

chain-hook seems to be missing the area base flag

before picture in #2224

after:
image

@pundm
Copy link
Contributor Author

pundm commented Feb 23, 2021

It was only showing me one changed file, now its 2 more here, i will see how i can fix the pull request. Sorry

@Wires77
Copy link
Member

Wires77 commented Feb 23, 2021

That's because I just forgot to merge a couple commits back into dev from master, so basing your branch off of master pulled those in.

Wires77
Wires77 requested changes Feb 23, 2021
View reviewed changes
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make the same edit to Export/Skills/act_str.txt. This file you edited is auto-generated by the exporter, and will get overwritten if the other file isn't changed as well.

@pundm
Copy link
Contributor Author

pundm commented Feb 23, 2021

Hey, i added the area tag in Export/Skills/act_str.txt
Sorry I'm a noob but i dont know how to get rid of the other 2 changed files. Should i delete the PR and try to make a new one from clean dev?

@Nostrademous Nostrademous requested a review from Wires77 February 23, 2021 15:45
@Nostrademous
Copy link
Contributor

LGTM

@Nostrademous Nostrademous added the bug Something isn't working label Feb 23, 2021
Wires77
Wires77 approved these changes Feb 23, 2021
View reviewed changes
Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, i added the area tag in Export/Skills/act_str.txt
Sorry I'm a noob but i dont know how to get rid of the other 2 changed files. Should i delete the PR and try to make a new one from clean dev?

Nope, you're good.

@ppoelzl ppoelzl merged commit c3fb301 into PathOfBuildingCommunity:dev Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wires77 Wires77 Wires77 approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pundm @Wires77 @Nostrademous @ppoelzl