Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Actum crit modifier #2326

Merged
merged 2 commits into from
Mar 18, 2021

Conversation

andrewbelu
Copy link
Contributor

With two actum's equipped (one 20% crit, one 30% crit):

image

Copy link
Contributor

@PJacek PJacek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect. You changed the base crit chance of the weapon.
crit

@andrewbelu
Copy link
Contributor Author

This is incorrect. You changed the base crit chance of the weapon.
crit

Ah, misread the mod, I thought it was base crit but as you mention looks to be the exact crit (who would use this axe lol). Will fix

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This wouldn't work against the old assassin's mark, which specified "Enemies have x% chance to be crit", but since they changed that wording and I don't know of anywhere else that was worded that way, this looks good to me.

@Wires77 Wires77 added the enhancement New feature, calculation, or mod label Mar 18, 2021
@Wires77 Wires77 merged commit a1af541 into PathOfBuildingCommunity:dev Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants