Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Portrait Mode #2443

Merged
merged 7 commits into from
Apr 22, 2021

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Apr 7, 2021

I actually think this looks pretty good and functional for a first pass, personally. The only thing left to do functionality-wise, is the Tree tab. The items tab gets a little cut off, but is usable.

@Wires77 Wires77 added enhancement New feature, calculation, or mod wip Unfinished and commited for discussion labels Apr 7, 2021
@Wires77
Copy link
Member Author

Wires77 commented Apr 7, 2021

Fixes #644

@Wires77 Wires77 removed the wip Unfinished and commited for discussion label Apr 15, 2021
@Wires77
Copy link
Member Author

Wires77 commented Apr 15, 2021

This is need of a refactor to reset the list instead of creating a new UI object each time, but I will leave that for a separate PR. This is ready for review.

@LocalIdentity LocalIdentity merged commit f99fe4e into PathOfBuildingCommunity:dev Apr 22, 2021
@Wires77 Wires77 deleted the portrait_mode branch April 22, 2021 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants