New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initialize Net::HTTP::Post with URI instead of string #28

Open

marcboquet wants to merge 1 commit into Patreon:master from Kit:http-req

marcboquet commented Nov 25, 2020

Initializing it with a string causes path to be incorrect:

url = URI.parse('https://www.patreon.com/api/oauth2/token')
req = Net::HTTP::Post.new(url.to_s)
req.path
# => "https://www.patreon.com/api/oauth2/token"

As opposed to

url = URI.parse('https://www.patreon.com/api/oauth2/token')
req = Net::HTTP::Post.new(url)
req.path
# => "/api/oauth2/token"

ruby-doc for Net::HTTP::Post shows initialization using a URI too.

Initializing with a string causes apm-agent-ruby to raise with URI::InvalidURIError. Related issue: elastic/apm-agent-ruby#834


          Initialize Net::HTTP::Post with URI instead of string

1f12ee2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet