Skip to content
This repository has been archived by the owner on Feb 9, 2024. It is now read-only.

158 rewrite logging things #160

Merged
merged 30 commits into from
Oct 31, 2023
Merged

158 rewrite logging things #160

merged 30 commits into from
Oct 31, 2023

Conversation

Jacob1010-h
Copy link
Member

#158 to add Smart Dashboard Logging and Driver UI compatibility. Sorry this took so long.

@Jacob1010-h Jacob1010-h added enhancement New feature or request autonomous Something that needs to get done for the Autonomous period of the match teleop Something that needs to get done for the Teleop period of the match labels Oct 31, 2023
@Jacob1010-h Jacob1010-h self-assigned this Oct 31, 2023
@Jacob1010-h Jacob1010-h linked an issue Oct 31, 2023 that may be closed by this pull request
@Jacob1010-h
Copy link
Member Author

I still need to resolve conflicts but, that's a later me issue, I need to do HW.
@GalexY727 if you get on before I'm done, your welcome to fix this, and incorporate it with the fixes that we did today with Loop Overruns

@Jacob1010-h Jacob1010-h marked this pull request as draft October 31, 2023 01:08
@GalexY727
Copy link
Member

Thanks for getting this started though :)

@Jacob1010-h
Copy link
Member Author

Everything should be good!! @GalexY727 I need you to go through this and make sure I haven't done anything dumb

@Jacob1010-h Jacob1010-h marked this pull request as ready for review October 31, 2023 02:46
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a couple of things here and there, mostly just making sure that we have init values being logged so that the NT shows the log before we enable the robot.
Other than that, make sure that the field2d position values are all the same from the last iteration of DriverUI (or revert all changes to DriverUI.java, doesn't matter)

EDIT: Please remember to remove all rioLog files!

src/main/java/frc/robot/util/DriverUI.java Outdated Show resolved Hide resolved
src/main/java/hardware/Swerve.java Show resolved Hide resolved
@Jacob1010-h
Copy link
Member Author

Jacob1010-h commented Oct 31, 2023

@GalexY727 please review quickly and merge

Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move around a couple lines of code, logic seems good though.

src/main/java/hardware/Swerve.java Outdated Show resolved Hide resolved
@Jacob1010-h Jacob1010-h merged commit fea4502 into main Oct 31, 2023
1 check passed
@Jacob1010-h Jacob1010-h deleted the 158-rewrite-logging-things branch October 31, 2023 18:32
@Jacob1010-h
Copy link
Member Author

Finally done!! This took me too long, but now I can work of command based a bit.

@GalexY727
Copy link
Member

woah woah woah what was that last commit, all the driver controls got removed from robot.java

@GalexY727
Copy link
Member

ah jeez man 8c66397

@Jacob1010-h
Copy link
Member Author

??? Wait what, I removed the driver controls????

@Jacob1010-h
Copy link
Member Author

Jacob1010-h commented Nov 1, 2023

Ur gonna have to elaborate

@Jacob1010-h
Copy link
Member Author

@GalexY727

@Jacob1010-h Jacob1010-h restored the 158-rewrite-logging-things branch November 1, 2023 19:27
Jacob1010-h added a commit that referenced this pull request Nov 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
autonomous Something that needs to get done for the Autonomous period of the match enhancement New feature or request teleop Something that needs to get done for the Teleop period of the match
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Rewrite Driver UI and the other logging things
3 participants