-
Notifications
You must be signed in to change notification settings - Fork 2
Conversation
I still need to resolve conflicts but, that's a later me issue, I need to do HW. |
Thanks for getting this started though :) |
Everything should be good!! @GalexY727 I need you to go through this and make sure I haven't done anything dumb |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of things here and there, mostly just making sure that we have init values being logged so that the NT shows the log before we enable the robot.
Other than that, make sure that the field2d position values are all the same from the last iteration of DriverUI (or revert all changes to DriverUI.java, doesn't matter)
EDIT: Please remember to remove all rioLog files!
@GalexY727 please review quickly and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move around a couple lines of code, logic seems good though.
Finally done!! This took me too long, but now I can work of command based a bit. |
woah woah woah what was that last commit, all the driver controls got removed from robot.java |
ah jeez man 8c66397 |
??? Wait what, I removed the driver controls???? |
Ur gonna have to elaborate |
#158 to add Smart Dashboard Logging and Driver UI compatibility. Sorry this took so long.