Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] #124 breaking MAXSwerveModule #129

Closed
GalexY727 opened this issue Feb 4, 2024 · 2 comments · Fixed by #183
Closed

[Bug] #124 breaking MAXSwerveModule #129

GalexY727 opened this issue Feb 4, 2024 · 2 comments · Fixed by #183
Assignees
@Hadizah454
Labels
bug Something isn't working help wanted Extra attention is needed logic A logic problem or solution subsystem A physical subsystem on the robot

Comments

@GalexY727
Copy link
Member

Bug + Desired Behavior

When running #100's branch in simulation, there appears to be some sort of issue with communicating to the motor what the desired speed is. As far as I can see it is got to do more with the turning motor rather than the driving one-- which makes me think

Possible Solutions

  • Is the feedback device being set in the PIDController correctly to an absolute encoder?
  • Is the motor inverting weirdly?
  • Is there a unit conversion error?
@GalexY727 GalexY727 added bug Something isn't working help wanted Extra attention is needed logic A logic problem or solution subsystem A physical subsystem on the robot labels Feb 4, 2024
@GalexY727 GalexY727 changed the title #124 breaking MAXSwerveModule [Bug] #124 breaking MAXSwerveModule Feb 4, 2024
@GalexY727 GalexY727 mentioned this issue Feb 4, 2024
Merged
@GalexY727 GalexY727 moved this to Ready in Crescendo 2024 Feb 4, 2024
@Hadizah454 Hadizah454 self-assigned this Feb 4, 2024
@Hadizah454 Hadizah454 moved this from Ready to In progress in Crescendo 2024 Feb 5, 2024
@Hadizah454
Copy link
Contributor

It seems to work fine in main and just isn't working on this branch I could be wrong though.

@GalexY727
Copy link
Member Author

That's the point of this bug. It comes from #100 and underscores a gap that we have in the logic of Neo.java with not having correct absolute encoder support.

@GalexY727 GalexY727 linked a pull request Feb 22, 2024 that will close this issue
Alas, the time for a new neo era #183
Merged
@github-project-automation github-project-automation bot moved this from In progress to Done in Crescendo 2024 Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Hadizah454 Hadizah454

Labels
bug Something isn't working help wanted Extra attention is needed logic A logic problem or solution subsystem A physical subsystem on the robot
Projects
Crescendo 2024
Archived in project
Milestone
No milestone
2 participants
@GalexY727 @Hadizah454