Alas, the time for a new neo era #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…axs :0 InSANE health and wellness, this guy needs a ambulance!1! 🤒
GalexY727
added
bug
This was
linked to
issues
Feb 22, 2024
Jacob1010-h
requested changes
Feb 22, 2024
src/main/java/frc/robot/subsystems/limelight/LimelightHelpers.java
Outdated
Show resolved
Hide resolved
remove unused variables and rename IZone method to use proper caps
GalexY727
requested review from
Oliver-Cushman
and removed request for
Jacob1010-h
|
surely frank is just waiting to review this one as well teehee |
|
whoever gets to it first >:) because i know you are itching to review it |
I have been waiting for this since 9:01 PM yesterday |
Jacob1010-h
approved these changes
Feb 22, 2024
src/main/java/frc/robot/subsystems/limelight/LimelightHelpers.java
Outdated
Show resolved
Hide resolved
sry I seeing comments and reviewing at the same time |
|
surely this won't have a breaking change when it gets tested on real sparks... oh no no no no no |
|
Absolutely not ....... |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need I say more? This guy is safe!