Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add note trajectory and visualization #110

Conversation

Jacob1010-h
Copy link
Member

It uses the calculated note trajectory to make an animation of the note shooting through the air. The Command to run this gets run on enabled but can be modified to do run later, elsewhere.

@Jacob1010-h Jacob1010-h added enhancement New feature or request logic A logic problem or solution command A command on the robot that controls a subsystem complicated It's as shrimple as that 🦐 labels Feb 1, 2024
@Jacob1010-h Jacob1010-h self-assigned this Feb 1, 2024
Jacob1010-h and others added 3 commits February 1, 2024 15:27
Co-authored-by: Alexander Hamilton <65139378+GalexY727@users.noreply.github.com>
@Jacob1010-h
Copy link
Member Author

this is ready to be reviewed

@Jacob1010-h Jacob1010-h linked an issue Feb 2, 2024 that may be closed by this pull request
4 tasks
@Jacob1010-h Jacob1010-h mentioned this pull request Feb 2, 2024
2 tasks
@Jacob1010-h Jacob1010-h linked an issue Feb 2, 2024 that may be closed by this pull request
1 task
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight changes, mainly in robotContainer's object handling

src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/NoteTrajectory.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/NoteTrajectory.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/NoteTrajectory.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/NoteTrajectory.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/NoteTrajectory.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/commands/ShooterCalc.java Outdated Show resolved Hide resolved
@Jacob1010-h
Copy link
Member Author

I feel as though the variables for the NoteTrajectory in Shooter Calc can be extracted into a class of possible variables, like Limelight Helpers @GalexY727

@GalexY727
Copy link
Member

I feel as though the variables for the NoteTrajectory in Shooter Calc can be extracted into a class of possible variables, like Limelight Helpers @GalexY727

e1125e3: Woah 😳
I was suggesting to move the object to be contained inside of ShooterCalc, but keep the variables and such in NoteTrajectory. I think its a good idea to keep it separate, it's just that it isn't needed inside of robotContainer, but rather could be an object inside of ShooterCalc

Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think fully containing NoteTrajectory in ShooterCalc isn't the best option, as ShooterCalc should just be our util method that handles abstract-er things like SpeedAngleTriplet

@Jacob1010-h
Copy link
Member Author

I feel as though the variables for the NoteTrajectory in Shooter Calc can be extracted into a class of possible variables, like Limelight Helpers @GalexY727

e1125e3: Woah 😳 I was suggesting to move the object to be contained inside of ShooterCalc, but keep the variables and such in NoteTrajectory. I think its a good idea to keep it separate, it's just that it isn't needed inside of robotContainer, but rather could be an object inside of ShooterCalc

OHHH!! I thought that was weird!! ok give me a sec

Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a single indent we should be good to gooo

src/main/java/frc/robot/commands/ShooterCalc.java Outdated Show resolved Hide resolved
@Jacob1010-h Jacob1010-h merged commit c7646b3 into 73-SWD-using-interpolation Feb 2, 2024
@Jacob1010-h Jacob1010-h deleted the 86-calculating-shooter-speeds-mathematically branch February 2, 2024 08:53
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍👍👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
command A command on the robot that controls a subsystem complicated It's as shrimple as that 🦐 enhancement New feature or request logic A logic problem or solution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Side quest for #86: Visualizing the note trajectory Calculating Shooter Speeds Mathematically
3 participants