-
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note trajectory and visualization #110
Add note trajectory and visualization #110
Conversation
Co-authored-by: Alexander Hamilton <a.hamilton72006@gmail.com>
WE just need to check if the note keeps its initial position, which it *should* but yknow
Co-authored-by: Alexander Hamilton <65139378+GalexY727@users.noreply.github.com>
this is ready to be reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Slight changes, mainly in robotContainer
's object handling
I feel as though the variables for the NoteTrajectory in Shooter Calc can be extracted into a class of possible variables, like Limelight Helpers @GalexY727 |
e1125e3: Woah 😳 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think fully containing NoteTrajectory in ShooterCalc isn't the best option, as ShooterCalc should just be our util method that handles abstract-er things like SpeedAngleTriplet
OHHH!! I thought that was weird!! ok give me a sec |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a single indent we should be good to gooo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍👍👍
It uses the calculated note trajectory to make an animation of the note shooting through the air. The Command to run this gets run on enabled but can be modified to do run later, elsewhere.