Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some triggers with HID instead #152

Merged
merged 10 commits into from
Feb 16, 2024
Merged

add some triggers with HID instead #152

merged 10 commits into from
Feb 16, 2024

Conversation

Jacob1010-h
Copy link
Member

No description provided.

@Jacob1010-h Jacob1010-h linked an issue Feb 11, 2024 that may be closed by this pull request
CommandXboxController creates CommandScheduler loop overruns #144
Closed
@Jacob1010-h Jacob1010-h added enhancement New feature or request ready to test Ready to test on the robot :> labels Feb 11, 2024
@Jacob1010-h Jacob1010-h self-assigned this Feb 11, 2024
@Jacob1010-h Jacob1010-h added this to the Finalize Tuning milestone Feb 11, 2024
GalexY727
GalexY727 requested changes Feb 15, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one or two lines need to be changed, surely.

src/main/java/frc/robot/util/PatriBoxController.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/PatriBoxController.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/util/PatriBoxController.java Outdated Show resolved Hide resolved
src/main/java/frc/robot/RobotContainer.java Outdated Show resolved Hide resolved
@GalexY727
Copy link
Member

I'm considering closing this PR due to 5478677

@GalexY727
Copy link
Member

I'm considering closing this PR due to 5478677

This should be cherry-picked into sim-dev (and main) if it isn't already

@Jacob1010-h
Copy link
Member Author

this is ready to go !!

@GalexY727
Copy link
Member

But isn't this pr just redundant and makes no changes to the main branches?

@Jacob1010-h
Copy link
Member Author

removed so much, but this is the corrected changes

@GalexY727
Copy link
Member

(i can't review right now because i'm on my phone)

@GalexY727
Copy link
Member

i have ideas for this pr though don't worry

Jacob1010-h referenced this pull request Feb 15, 2024
@PatribotsProgramming
resolve #144 :D
5478677
@Jacob1010-h
Copy link
Member Author

(i can't review right now because i'm on my phone)

sounds good, not much was changed, but it just does the referenced above, but not using HID in the Container

@Jacob1010-h Jacob1010-h mentioned this pull request Feb 15, 2024
Closed
@PatribotsProgramming PatribotsProgramming deleted the 144-controller-commandscheduler-loop-fix branch February 16, 2024 23:27
@PatribotsProgramming PatribotsProgramming restored the 144-controller-commandscheduler-loop-fix branch February 16, 2024 23:27
@GalexY727 GalexY727 self-requested a review February 16, 2024 23:28
GalexY727
GalexY727 requested changes Feb 16, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 more buttons and we merg! E!EE!e1 Ewjheqadwalsnda

src/main/java/frc/robot/util/PatriBoxController.java Show resolved Hide resolved
src/main/java/frc/robot/util/PatriBoxController.java Show resolved Hide resolved
@GalexY727
Copy link
Member

🦞🦞🦞

@GalexY727 GalexY727 self-requested a review February 16, 2024 23:40
GalexY727
GalexY727 approved these changes Feb 16, 2024
View reviewed changes
Copy link
Member

@GalexY727 GalexY727 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gooder

@GalexY727 GalexY727 merged commit 50cee8e into sim-dev Feb 16, 2024
@GalexY727 GalexY727 deleted the 144-controller-commandscheduler-loop-fix branch February 16, 2024 23:52
@PatribotsProgramming
Copy link
Member

CLOSES #144

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GalexY727 GalexY727 GalexY727 approved these changes

Assignees

@Jacob1010-h Jacob1010-h

Labels
enhancement New feature or request ready to test Ready to test on the robot :>
Projects
None yet
Milestone
Finalize Tuning
Development

Successfully merging this pull request may close these issues.

CommandXboxController creates CommandScheduler loop overruns
3 participants
@Jacob1010-h @GalexY727 @PatribotsProgramming