Add deviceId to existing devices on init

PatrickE94 · Oct 23, 2024 · f485756 · f485756
1 parent 124a1b8
commit f485756
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 0 deletions.
diff --git a/drivers/go/device.ts b/drivers/go/device.ts
@@ -30,6 +30,7 @@ export class GoCharger extends Homey.Device {
     );
 
     await this.migrateCapabilities();
+    await this.migrateSettings();
     this.registerCapabilityListeners();
 
     this.cronTasks.push(
@@ -44,6 +45,29 @@ export class GoCharger extends Homey.Device {
     this.log('GoCharger has been initialized');
   }
 
+      /**
+   * Migrate settings from the old settings format to the new one.
+   * If the deviceid setting is empty, poll the charger info and store the device id.
+   */
+      private async migrateSettings() {
+        if (this.api === undefined) return;
+
+        if (this.getSetting('deviceid') === ""){
+          await this.api.getCharger(this.getData().id)
+          .then((charger) => {    
+            this.setSettings({
+              deviceid: charger.DeviceId,
+            });
+          })
+          .then(() => {
+            this.logToDebug(`Got charger info - added device id`);
+          })
+          .catch((e) => {
+            this.logToDebug(`Failed to poll charger info: ${e}`);
+          });
+        }
+      }
+
   /**
    * Verify all expected capabilities and apply changes to capabilities.
    *

diff --git a/drivers/home/device.ts b/drivers/home/device.ts
@@ -30,6 +30,7 @@ export class ProCharger extends Homey.Device {
     );
 
     await this.migrateCapabilities();
+    await this.migrateSettings();
     this.registerCapabilityListeners();
 
     this.cronTasks.push(
@@ -44,6 +45,29 @@ export class ProCharger extends Homey.Device {
     this.log('ProCharger has been initialized');
   }
 
+    /**
+   * Migrate settings from the old settings format to the new one.
+   * If the deviceid setting is empty, poll the charger info and store the device id.
+   */
+    private async migrateSettings() {
+      if (this.api === undefined) return;
+
+      if (this.getSetting('deviceid') === ""){
+        await this.api.getCharger(this.getData().id)
+        .then((charger) => {    
+          this.setSettings({
+            deviceid: charger.DeviceId,
+          });
+        })
+        .then(() => {
+          this.logToDebug(`Got charger info - added device id`);
+        })
+        .catch((e) => {
+          this.logToDebug(`Failed to poll charger info: ${e}`);
+        });
+      }
+    }
+
   /**
    * Verify all expected capabilities and apply changes to capabilities.
    *

diff --git a/drivers/pro/device.ts b/drivers/pro/device.ts
@@ -30,6 +30,7 @@ export class ProCharger extends Homey.Device {
     );
 
     await this.migrateCapabilities();
+    await this.migrateSettings();
     this.registerCapabilityListeners();
 
     this.cronTasks.push(
@@ -44,6 +45,29 @@ export class ProCharger extends Homey.Device {
     this.log('ProCharger has been initialized');
   }
 
+  /**
+   * Migrate settings from the old settings format to the new one.
+   * If the deviceid setting is empty, poll the charger info and store the device id.
+   */
+  private async migrateSettings() {
+    if (this.api === undefined) return;
+
+    if (this.getSetting('deviceid') === ""){
+      await this.api.getCharger(this.getData().id)
+      .then((charger) => {    
+        this.setSettings({
+          deviceid: charger.DeviceId,
+        });
+      })
+      .then(() => {
+        this.logToDebug(`Got charger info - added device id`);
+      })
+      .catch((e) => {
+        this.logToDebug(`Failed to poll charger info: ${e}`);
+      });
+    }
+  }
+
   /**
    * Verify all expected capabilities and apply changes to capabilities.
    *