Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding webpack-dev-server #209

Closed
wants to merge 6 commits into from

Conversation

washingtonsoares
Copy link

@washingtonsoares washingtonsoares commented Mar 1, 2017

Hey folks!

I really enjoyed this starter project and it helped me a lot when i was looking to start a project.

However I realized that it was possible to improve it in some points, among them:

  • Using webpack-dev-server:
    With webpack-dev-server it is possible to have a greater integration with webpack,
    Besides being a server with a very simple configuration to serve the webpack bundles.

  • Using Gulp only to generate new components:
    On Gulp I think it would only be necessary to generate new components,
    because the responsibles for generating the bundles would be webpack and the server for webpack-dev-server.

Also I have updated some dev dependencies, like the loaders and the webpack itself.

I believe that these changes will bring improvements and more users to this
starter project and will certainly continue to help many devs who are starting a project!

Kindly look at this PR, and Come to me if you need anything to be adjusted.

Thanks!

@jayrmotta
Copy link

👍

1 similar comment
@jvpsousa
Copy link

jvpsousa commented Mar 1, 2017

👍

package.json Outdated
"start": "gulp serve",
"build": "webpack --progress --config ./webpack.dist.config.js",
"serve": "webpack-dev-server --progress --config ./webpack.dev.config.js",
"start": "webpack-dev-server --progress --config ./webpack.dev.config.js",
Copy link
Collaborator

@fesor fesor Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe we should move all webpack configs to separate directory? Leaving just webpack.config.js in root directory which will load correct config depending on environment?

Copy link
Author

@washingtonsoares washingtonsoares Mar 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea
I will refactor and update the PR.

"start": "gulp serve",
"build": "webpack --progress --config ./config/webpack.prod.config.js",
"serve": "webpack-dev-server --progress --config ./config/webpack.dev.config.js",
"start": "webpack-dev-server --progress --config ./config/webpack.dev.config.js",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be awesome if we would have single entry point for config. Something like that.

@andrei-dracea
Copy link

Who else needs to review this in order to merge it? What are the next steps?

@fesor
Copy link
Collaborator

fesor commented Apr 22, 2017

The only problem that I see with this PR is that it removes browser-sync. This is pretty useful tool for cross-device testing.

Also there was some stuff which could be improved in webpack configuration management.

@PatrickJS
Copy link
Owner

@fesor is this PR good?

@scragg0x
Copy link

scragg0x commented Aug 2, 2017

Could this plugin be used for browser-sync? I have never used it myself.
https://www.npmjs.com/package/browser-sync-webpack-plugin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants