Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: State Management #1121

Closed
CharlieGreenman opened this issue Oct 23, 2016 · 4 comments
Closed

Feature Request: State Management #1121

CharlieGreenman opened this issue Oct 23, 2016 · 4 comments

Comments

@CharlieGreenman
Copy link

CharlieGreenman commented Oct 23, 2016

  • I'm submitting a ...
    [ ] bug report
    [X] feature request
    [ ] question about the decisions made in the repository
  • Do you want to request a feature or report a bug?
    Feature
  • What is the current behavior?
    App does not currently allow for state management out of the box.
  • What is the expected behavior?
    Build system should have the ability to manage state, using either ngrx, or ng2-redux.
  • What is the motivation / use case for changing the behavior?
    Ability to manage state using ngrx, or ng2-redux. (Ideally, ngrx.)
  • Please tell us about your environment:
  • Angular version: 2.0.0-beta.X
  • Browser: all
@joshwiens
Copy link
Contributor

@CharlieGreenman - This would be something that belongs on a fork of the angular2-webpack-starter. My suggestion would be to go the route that NathanWalker went with https://github.com/NathanWalker/angular-seed-advanced

Not everyone wants / needs something like ngrx.

As an aside, professionally I run a heavily modified version of the webpack-starter with ngrx / scss & a few other goodies. If you were interested in maintaining a feature fork for ngrx, i'd certainly be up for contributing to it.

@CharlieGreenman
Copy link
Author

CharlieGreenman commented Oct 27, 2016

Ok. I was thinking of contributing to https://github.com/qdouble/angular-webpack2-starter. However, https://github.com/NathanWalker/angular-seed-advanced does seem to be better off for this stage in things. It's just that angular2-seed-advanced is too jammed pack, with Electron/Nativescript in particular. I'll take my reservations over to angular2-seed-advanced if need be.

@joshwiens
Copy link
Contributor

@CharlieGreenman I wasn't necessarily suggesting you contribute to a different repo.

To be clear, I was suggesting you create a fork of this repo and modify it to run ngrx as an example / base seed for those that want to get into redux.

Nathan's advanced seed is great but it's based on SystemJS, if you want to use Webpack ( my personal choice ) that is going to be a big change. I've looked at the angular-webpack2-starter it's solid work but imho it's a bit cluttered for my taste.

In the end I personally forked this repo & added ngrx, scss & material2 and it's maintained independently at this point.

@CharlieGreenman
Copy link
Author

CharlieGreenman commented Oct 27, 2016

Hey @d3viant0ne , I actually did realize that! I also realized after writing what
I should mention it, but was caught up at the time :)

That being said, would you be interested in open sourcing the your personal repo that has ngrx and scss. I would be more than interested in maintaining. Regardless, I am going to go ahead and create a ngrx/scss version of this repo. Thank you.

On Oct 27, 2016 1:16 AM, "Joshua Wiens" notifications@github.com wrote:

@CharlieGreenman https://github.com/CharlieGreenman I wasn't
necessarily suggesting you contribute to a different repo.

To be clear, I was suggesting you create a fork of this repo and modify it
to run ngrx as an example / base seed for those that want to get into redux.

Nathan's advanced seed is great but it's based on SystemJS, if you want to
use Webpack ( my personal choice ) that is going to be a big change. I've
looked at the angular-webpack2-starter it's solid work but imho it's a
bit cluttered for my taste.

In the end I personally forked this repo & added ngrx, scss & material2
and it's maintained independently at this point.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#1121 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AIJP7RAUNlpJ4JA559DVTlsnQMJs3HIkks5q4DOrgaJpZM4KeB-8
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants