Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: examples/large-app #104

Merged
merged 2 commits into from
Oct 28, 2015
Merged

Fix: examples/large-app #104

merged 2 commits into from
Oct 28, 2015

Conversation

dotcs
Copy link
Contributor

@dotcs dotcs commented Oct 21, 2015

I have fixed several issues with angular2@2.0.0-alpha.44. Furthermore I have fixed a broken import (see a493839#commitcomment-13901195).

I also changed an import statement to keep the syntax the same across the application, because webpack complained about the import:

There is another module with an equal name when case is ignored.
This can lead to unexpected behavior when compiling on a filesystem with other case-semantic.
Rename module if multiple modules are expected or use equal casing if one module is expected.

There are still some issues with the 'search github' and 'todo' components, but the router does work again and at least webpack compiles without an error. This PR fixes #92.

@dotcs
Copy link
Contributor Author

dotcs commented Oct 21, 2015

I forgot to mention that I have disabled the 'draggable_div' example because I could not find out how to include it properly. To me it seems as this component has been abandoned. Any help on how to include this component is appreciated.

@dotcs
Copy link
Contributor Author

dotcs commented Oct 23, 2015

Update: I have fixed the 'search github' example in PR #107.

@SekibOmazic
Copy link
Contributor

@dotcs Could you please rebase and resolve merge conflicts? Your PR also collides with #111 (although #111 just disables rxjs examples)

@dotcs
Copy link
Contributor Author

dotcs commented Oct 28, 2015

@SekibOmazic Done. The I have enabled the rxjs examples again. With the fixes in #107 all rxjs examples are working fine again. Please give it a try.

@SekibOmazic
Copy link
Contributor

LGTM

SekibOmazic added a commit that referenced this pull request Oct 28, 2015
@SekibOmazic SekibOmazic merged commit 062407a into PatrickJS:master Oct 28, 2015
@SekibOmazic
Copy link
Contributor

@dotcs Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No router example working
2 participants