Fix directive for route active #368
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I forgot to specify the test scenario :s my bad. Crisis Center -> Dragon Burning Cities I think the the ChildRoute doesn't fire event to the subscribe when the RootRouter change. |
|
LGTM |
PatrickJS
added a commit
that referenced
this pull request
Mar 1, 2016
Fix directive for route active
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix the directive that put a 'active' class on active link.
In a case with a 2 level of routeConfig the second level is not correctly define.
Fixed version
http://plnkr.co/edit/vleQ7C7Z0VBwrwx46UO3?p=preview
Original version
http://plnkr.co/edit/3ZbRYYzIxiiliP2Gbzm7?p=preview