Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Style: 03-05 and 03-06 #583

Merged
merged 2 commits into from
May 13, 2016
Merged

Style: 03-05 and 03-06 #583

merged 2 commits into from
May 13, 2016

Conversation

dweitz43
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Update to conform to Angular Style Guide

  • What is the current behavior? (You can also link to an open issue here)

some source files violate Coding Conventions rules on Import Destructuring Spacing (03-05) and Import Line Spacing (03-06)

  • What is the new behavior (if this is a feature change)?

source conforms to style guide rules 03-05 and 03-06

  • Other information:

Style 03-05: Import Destructuring Spacing
-Do leave one whitespace character inside of the import statements' curly braces when destructuring.
-Why? Whitespace makes it easier to read the imports.

Style 03-06: Import Line Spacing
-Do leave one empty line between third party imports and imports of code we created.
-Do list import lines alphabetized by the module.
-Do list destructured imported assets alphabetically.
-Why? The empty line makes it easy to read and locate imports.
-Why? Alphabetizing makes it easier to read and locate imports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants