Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better filesGlob in tsconfig #595

Merged
merged 3 commits into from
May 16, 2016
Merged

Better filesGlob in tsconfig #595

merged 3 commits into from
May 16, 2016

Conversation

abdulhaq-e
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Feature
  • What is the current behavior? (You can also link to an open issue here)
    Atom-typscript is slow
  • What is the new behavior (if this is a feature change)?
    Atom-typescript is a little bit faster (or at least I think it is)
  • Other information:
    From @basarat himself:

the filesGlob should be "!node_modules/**", instead of "!node_modules/**/*.ts", Same for other excludes 🌹 That should fix it for you 🚀

More info is available on the atom-typescript faq

@abdulhaq-e
Copy link
Contributor Author

I don't know why 3 commits appeared. Can someone tell me why?

I merged from upstream, edited the files and committed! Should I have rebased?

@PatrickJS PatrickJS merged commit 7fd88dc into PatrickJS:master May 16, 2016
@PatrickJS
Copy link
Owner

thanks

awcodify pushed a commit to awcodify/d3-angular-4 that referenced this pull request Aug 28, 2017
* chore: remove unused import

* Better filesGlob in tsconfig
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants