Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix fakyAsync and sync test #609

Merged
merged 1 commit into from
May 19, 2016
Merged

fix fakyAsync and sync test #609

merged 1 commit into from
May 19, 2016

Conversation

abdulhaq-e
Copy link
Contributor

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Bug fix
  • What is the current behavior? (You can also link to an open issue here)
    Cannot run fakeAsync tests, see issue fakeAsync is not working with webpack #590
  • What is the new behavior (if this is a feature change)?
    fakeAsync tests run successfully. Sync tests may also be effected so this PR also adds the relevant zone file.
  • Other information:

@abdulhaq-e abdulhaq-e mentioned this pull request May 19, 2016
Closed
@PatrickJS PatrickJS merged commit 11f0713 into PatrickJS:master May 19, 2016
@PatrickJS
Copy link
Owner

thanks!

awcodify pushed a commit to awcodify/d3-angular-4 that referenced this pull request Aug 28, 2017
@abdulhaq-e @PatrickJS
fix: fakyAsync and sync test (PatrickJS#609)
6cc5dae
@MaxMood96 MaxMood96 mentioned this pull request Jan 12, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@abdulhaq-e @PatrickJS