Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Local inject doesn't work for IE10 and 11 #379

Closed
cornae opened this issue Aug 28, 2014 · 1 comment
Closed

Local inject doesn't work for IE10 and 11 #379

cornae opened this issue Aug 28, 2014 · 1 comment
Assignees

Comments

@cornae
Copy link
Member

cornae commented Aug 28, 2014

This issue came in from @frontendplace. (original text below) Local injection (<a href="#someID" class="pat-inject" ) doesn't seem to work for IE10 and 11. @frontendplace has an isolated example available.

Does not work in IE 10/11:

<a href="#footermenu" class="pat-inject" data-pat-inject="target: self::element; trigger:autoload">To menu</a>

Works:

<a href=index.html#footermenu" class="pat-inject" data-pat-inject="target: self::element; trigger:autoload">To menu</a>

De ajax injectie werkt niet voor ie11 als het om een locale injectie gaat.
voeren we de naam in van het document zelf ( opnieuw ophalen van content) dan werkt het wel

dus Naar menu werkt niet en
<a href=独ndex.html#footermenu" class="pat-inject" data-pat-inject="target: self::element; trigger:autoload">Naar menu werkt wel.

Dit geldt niet voor firefox, safari en chrome daar werkt het wel goed.
heb jij enig idee hoe dit kan?

@jcbrand jcbrand assigned jcbrand and unassigned pilz Sep 2, 2014
jcbrand added a commit that referenced this issue Sep 5, 2014
jcbrand added a commit that referenced this issue Sep 5, 2014
IE 10/11 was failing because an ajax request was being made with the url
paramater being ''.

Chrome et al. will in this case request the current page, but IE instead
throws a SyntaxError.

However, if the url is '', then we are actually intending to inject content
from the current page, which means that an ajax request is unnecessary.

So the fix is to fetch the content from the current page instead of making an
ajax request.
@jcbrand
Copy link
Member

jcbrand commented Sep 5, 2014

IE 10/11 was failing because an ajax request was being made with the url paramater being an empty string.

Chrome et al. will in this case request the current page, but IE instead throws a SyntaxError.

However, if the url is an empty string, then we are actually intending to inject content from the current page, which means that an ajax request is unnecessary.

So the fix is to fetch the content from the current page instead of making an ajax request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants