attempt to simplify tvac handling #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression tests all passed:
https://github.com/spacetelescope/RegressionTests/actions/runs/10203240767/job/28229237578
@PaulHuwe I believe this will address the 2 issues
I've tested spacetelescope#362 which I believe is also covered by the unit test changes you made, thanks for those!
I have not yet tested spacetelescope#361 (and I may have deleted the large input file to free up space, I'll need to check).
Checklist
CHANGES.rstunder the corresponding subsection