Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce flow errors to 0 #251

Merged
merged 4 commits into from
Nov 7, 2016
Merged

Reduce flow errors to 0 #251

merged 4 commits into from
Nov 7, 2016

Conversation

joeyrosztoczy
Copy link
Contributor

Hi Paul. I've reopened the PR against next


Hello! We're using react-leaflet for an internal tool where I just added flow and wanted to help update react-leaflet. This is my first attempt to contribute to an OS library, so please let me know if there's any feedback you have for me.

Main changes:

  • ignore node_modules/fbjs, this library seems to always be throwing flow errors everywhere I use it (including here)
  • add annotations to component functions
  • add annotations to component returns
  • make sure inherited propTypes are specified

@PaulLeCam PaulLeCam merged commit bff0861 into PaulLeCam:next Nov 7, 2016
@PaulLeCam
Copy link
Owner

Great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants