Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding some tests #406

Merged
merged 2 commits into from
Oct 31, 2017
Merged

adding some tests #406

merged 2 commits into from
Oct 31, 2017

Conversation

uxtx
Copy link
Contributor

@uxtx uxtx commented Oct 30, 2017

  • viewport options, and change events effecting viewports
  • asserting tearDown clears out leaflet element

adding some tests
8ac66b9 
- viewport options, and change events effecting viewports
- asserting tearDown clears out leaflet element
PaulLeCam
PaulLeCam requested changes Oct 31, 2017
View reviewed changes
Copy link
Owner

@PaulLeCam PaulLeCam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR! Could you please remove these unrelated changes?

.gitignore Outdated
@@ -1,6 +1,6 @@
node_modules
coverage

.DS_Store
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm happy to -but this is a standard cruft meta-data file automagically created in mac environments - without it - most contributors on macs may inadvertently slip up and commit .DS_Store files.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes I agree these files are annoying, but I think this should be part of developers own git config rather than polluting projects with this, especially since there are different files based on each OS and IDE.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works for me!

.nvmrc Outdated
@@ -0,0 +1 @@
6
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove

@uxtx
Copy link
Contributor Author

uxtx commented Oct 31, 2017

@PaulLeCam updated per your suggestions here - thanks for the feedback.

@PaulLeCam PaulLeCam merged commit cbd8487 into PaulLeCam:master Oct 31, 2017
@PaulLeCam
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulLeCam PaulLeCam PaulLeCam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@uxtx @PaulLeCam