Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dotenv in favor of configuration variables #178

Merged
merged 11 commits into from
Nov 26, 2023
Merged

Remove dotenv in favor of configuration variables #178

merged 11 commits into from
Nov 26, 2023

Conversation

fvictorio
Copy link
Contributor

This PR adapts the template to use Configuration variables instead of dotenv and environment variables.

fvictorio
fvictorio commented Nov 7, 2023
View reviewed changes
.solcover.js Show resolved Hide resolved
fvictorio
fvictorio commented Nov 7, 2023
View reviewed changes
package.json Show resolved Hide resolved
@fvictorio fvictorio force-pushed the feature/convert-env-vars-to-config-vars branch from d7509dd to 36e325b Compare November 10, 2023 10:27
PaulRBerg
PaulRBerg approved these changes Nov 26, 2023
View reviewed changes
Copy link
Owner

@PaulRBerg PaulRBerg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @fvictorio for making this template better.

@PaulRBerg PaulRBerg merged commit 1e00b94 into PaulRBerg:main Nov 26, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PaulRBerg PaulRBerg PaulRBerg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fvictorio @PaulRBerg @ChristopherDedominici