Skip to content

Commit

Permalink
Update README.md (facebook#3717)
Browse files Browse the repository at this point in the history
* Update README.md with a note that reminds users to prepend REACT_APP_ to their environment variables. 
* Based on facebook#865, where Dan Abramov suggests the person who filed the issue create a PR with these changes.
* Took the language from [Adding Custom Environment Variables](https://github.com/facebookincubator/create-react-app/tree/master/packages/react-scripts/template#adding-custom-environment-variables)
  • Loading branch information
maecapozzi authored and Pavel Zhytko committed Jul 10, 2018
1 parent dbe3369 commit d1c0c23
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions packages/react-scripts/template/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -944,6 +944,7 @@ To define permanent environment variables, create a file called `.env` in the ro
```
REACT_APP_SECRET_CODE=abcdef
```
>Note: You must create custom environment variables beginning with `REACT_APP_`. Any other variables except `NODE_ENV` will be ignored to avoid [accidentally exposing a private key on the machine that could have the same name](https://github.com/facebookincubator/create-react-app/issues/865#issuecomment-252199527). Changing any environment variables will require you to restart the development server if it is running.
`.env` files **should be** checked into source control (with the exclusion of `.env*.local`).

Expand Down

0 comments on commit d1c0c23

Please sign in to comment.