Skip to content
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.

Remove "[english]" and "GameUI_vote_failed_vote_in_progress" strings in closecaption_ files #390

Open
Tiagoquix opened this issue Mar 10, 2022 · 1 comment
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement New feature or request

Comments

@Tiagoquix
Copy link
Contributor

Tiagoquix commented Mar 10, 2022

They are useless and make no difference. The proof of this is that you can open the file tf_brazilian.txt, tf_german.txt, tf_ukrainian.txt etc. and you will see that none of them have "[english]" strings.

These strings were probably used for some checking purpose in the past, but the translation file formats have changed recently and "[english]" has been removed from the files.

In short: the presence of the "[english]" strings is not necessary for the custom files to work.

@ClusterConsultant ClusterConsultant added Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement New feature or request labels Mar 10, 2022
@Tiagoquix
Copy link
Contributor Author

I would also like to point out that I do not think the change to GameUI_vote_failed_vote_in_progress in the closecaption_ files is necessary, since basically it only defines the string to be displayed on the panel when the vote fails, but the vote eraser addon ends up hiding everything in the panel.

As a reference, the string "GameUI_vote_failed" "Vote Failed" also appears in the same panel as GameUI_vote_failed_vote_in_progress, but it is not changed by the closecaption_ files.

@Tiagoquix Tiagoquix changed the title Remove "[english]" strings in closecaption_ files Remove "[english]" and "GameUI_vote_failed_vote_in_progress" strings in closecaption_ files Mar 14, 2022
surepy added a commit to surepy/tf2_bot_detector that referenced this issue May 12, 2023
surepy added a commit to surepy/tf2_bot_detector that referenced this issue Jun 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Priority: Low This issue can probably be picked up by anyone looking to contribute to the project, as an entry fix Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants