fix: touchables not registering touches after scrolling

Stopping the scroll was causing a glitch. Seems like a react-native bug of some sort. Fixes #123
PedroBern · Feb 18, 2021 · 5598b11 · 5598b11
1 parent cc9aeab
commit 5598b11
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 20 deletions.
diff --git a/example/src/Shared/Contacts.tsx b/example/src/Shared/Contacts.tsx
@@ -1,5 +1,11 @@
 import * as React from 'react'
-import { View, Text, StyleSheet, Platform } from 'react-native'
+import {
+  View,
+  Text,
+  StyleSheet,
+  Platform,
+  TouchableOpacity,
+} from 'react-native'
 import * as Tabs from 'react-native-collapsible-tab-view'
 import Animated, {
   useAnimatedStyle,
@@ -70,17 +76,19 @@ class ContactItem extends React.PureComponent<{
     const { item } = this.props
 
     return (
-      <View style={styles.item}>
-        <View style={styles.avatar}>
-          <Text style={styles.letter}>
-            {item.name.slice(0, 1).toUpperCase()}
-          </Text>
+      <TouchableOpacity>
+        <View style={styles.item}>
+          <View style={styles.avatar}>
+            <Text style={styles.letter}>
+              {item.name.slice(0, 1).toUpperCase()}
+            </Text>
+          </View>
+          <View style={styles.details}>
+            <Text style={styles.name}>{item.name}</Text>
+            <Text style={styles.number}>{item.number}</Text>
+          </View>
         </View>
-        <View style={styles.details}>
-          <Text style={styles.name}>{item.name}</Text>
-          <Text style={styles.number}>{item.number}</Text>
-        </View>
-      </View>
+      </TouchableOpacity>
     )
   }
 }

diff --git a/src/hooks.tsx b/src/hooks.tsx
@@ -377,15 +377,6 @@ export const useScrollHandlerY = (
       onBeginDrag: () => {
         if (!enabled) return
 
-        // workaround to stop animated scrolls
-        scrollTo(
-          refMap[name],
-          0,
-          scrollY.value[tabIndex] + 0.1,
-          false,
-          `[${name}] stop scroll`
-        )
-
         // ensure the header stops snapping
         cancelAnimation(accDiffClamp)