Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strange issue with indicator appearing under wrong tab #100

Closed
alexpchin opened this issue Feb 8, 2021 · 1 comment · Fixed by #93
Closed

Strange issue with indicator appearing under wrong tab #100

alexpchin opened this issue Feb 8, 2021 · 1 comment · Fixed by #93
Labels
bug Something isn't working

Comments

@alexpchin
Copy link
Contributor

I'm still trying to work out exactly the scenario that this happens in, but sometimes the indicator shows underneath the wrong tab.

image
@alexpchin alexpchin added the bug Something isn't working label Feb 8, 2021
@PedroBern
Copy link
Owner

🎉 issue #100 🎉

@alexpchin this is probably fixed in #93

@PedroBern PedroBern linked a pull request Feb 9, 2021 that will close this issue
Version 4.0 with api refactoring and dynamic tabs #93
Merged
PedroBern added a commit that referenced this issue Feb 9, 2021
@PedroBern
Merge pull request #93 from andreialecu/refactor-apicleanup3
03e7202 
Version 4.0 with api refactoring and dynamic tabs.

BREAKING CHANGES:

createCollapsibleTabs() no longer exists. Instead the library exports different components (Container, Tab, ScrollView, ListView) which can be nested like normal react components.
refMap no longer exists, and creating refs is no longer necessary (it's all handled internally)
ScrollView/FlatList now forward their refs, so the caller can just tap into their ref prop
the existing onIndexChange was renamed to onTabChange, and a separate onIndexChange was implemented that just returns the new index (as a number)
diffClampEnabled was changed to revealHeaderOnScroll
redundant prop snapEnabled was removed, instead snapThreshold is number | null | undefined. If not a number, then snap is not enabled. Setting it to 0.5 will result in snapping in the middle, like in the previous version.

Fixes: #100, #98, #94, #88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Version 4.0 with api refactoring and dynamic tabs andreialecu/react-native-collapsible-tab-view
2 participants
@alexpchin @PedroBern