Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content showing below header until move #113

Closed
alexpchin opened this issue Feb 10, 2021 · 8 comments · Fixed by #114
Closed

Content showing below header until move #113

alexpchin opened this issue Feb 10, 2021 · 8 comments · Fixed by #114
Labels
bug Something isn't working

Comments

@alexpchin
Copy link
Contributor

On initial load, the content shows below the header.

Screenshot 2021-02-10 at 16 13 05

After scrolling, the content then moves to the correct place. @andreialecu Does this happen on the updated PR for you too? andreialecu/rnctv-react-native-bare-test#1 I am concerned as I'm still not seeing the indicator when scrollEnabled is set as per #109

@alexpchin alexpchin added the bug Something isn't working label Feb 10, 2021
@andreialecu
Copy link
Collaborator

I can repro this one. Checking.

@andreialecu
Copy link
Collaborator

@alexpchin can you do me a favor and pull the change I made to the PR and tell me if you can also see this extra space between the tab bar and the albums when scrolling down?

simulator_screenshot_9D5DA805-AFF5-4327-B30B-12A7EFED4A9C

@alexpchin
Copy link
Contributor Author

@andreialecu Yes, I also see that after I have scrolled down.

@alexpchin
Copy link
Contributor Author

Also... I've just noticed, I can see the indicator too.

@andreialecu
Copy link
Collaborator

andreialecu commented Feb 10, 2021

I found what the problem is. Seems to be a difference between Expo and bare RN.

More specifically it seems that automaticallyAdjustContentInsets needs to be set to false on the inner scroll view.

This resolves the main issue you're seeing. Will open a PR shortly after testing it further.

@andreialecu
Copy link
Collaborator

If you manually edit this file in node_modules, as per the screenshot below, this should work:

Screenshot 2021-02-10 at 19 43 34

@andreialecu
Copy link
Collaborator

@alexpchin try 4.0.0-rc.2

@alexpchin
Copy link
Contributor Author

alexpchin commented Feb 10, 2021

Thanks! @andreialecu I'll check that now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants