-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: tab indicator did not work correctly in RTL mode #193
Conversation
this add should import and help invisible indicator in RTL mode
fixed invisible indicator in RTL
Released in 4.3.0 🚀 |
@andreialecu thank you for your work. But there's a problem. With this, the tab orders on the header are reversed. Also the indicator is moving with respect to rtl. However actual rendered tab orders did not change. Ex: initial page is page 1 normal LTR: RTL: Rendered page orders should be reversed too. In order to fix it, I have to give my tabs in reversed order,
and then use it. As well as giving MaterialTabBar a conditional style, which gives flexDirection row or row-reverse accordingly. For my app to align rendered pages as in order of 3 | 2 | 1 too. So please, include this behavior in RTL too. More important, when I do these changes, the indicator gets reversed once more because of my additions above yours outside the package, and gets outside of screen with it's intended animation leftwards. |
Would you like to open a PR with the fix? |
what => fix invisible indicator in RTL mode
why => Tab bar indicator not works as expected in RTL mode
how => just added v.x * -1 in RTL mode, otherwise will be v.x