Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error messages in ReduceASLFiles #379

Merged
merged 6 commits into from
Dec 20, 2023
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Dec 18, 2023

Closes none, but should make the error messages that could be raised by ReduceASLFiles more informative.

I noticed some related errors in the Sentry logs for this week.

Changes proposed:

@tsalo tsalo added enhancement New feature or request ignore-for-release PRs that shouldn't be included with release notes. labels Dec 18, 2023
@codecov-commenter
Copy link

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (d6c868c) 78.98% compared to head (780cfcd) 78.90%.

Files Patch % Lines
aslprep/interfaces/utility.py 50.00% 1 Missing and 1 partial ⚠️
aslprep/utils/asl.py 50.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
- Coverage   78.98%   78.90%   -0.08%     
==========================================
  Files          39       39              
  Lines        4149     4153       +4     
  Branches      602      604       +2     
==========================================
  Hits         3277     3277              
- Misses        676      678       +2     
- Partials      196      198       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo
Copy link
Member Author

tsalo commented Dec 19, 2023

test_001 may not have the necessary metadata for SyN:

Traceback:
        Traceback (most recent call last):
          File "/usr/local/miniconda/lib/python3.10/site-packages/nipype/interfaces/base/core.py", line 397, in run
            runtime = self._run_interface(runtime)
          File "/usr/local/miniconda/lib/python3.10/site-packages/sdcflows/interfaces/epi.py", line 57, in _run_interface
            self._results["readout_time"] = get_trt(
          File "/usr/local/miniconda/lib/python3.10/site-packages/sdcflows/utils/epimanip.py", line 228, in get_trt
            raise ValueError("Unknown total-readout time specification")
        ValueError: Unknown total-readout time specification

@tsalo tsalo merged commit 2dfe72b into PennLINC:main Dec 20, 2023
25 checks passed
@tsalo tsalo deleted the improve-errors branch December 20, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ignore-for-release PRs that shouldn't be included with release notes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pin to SDCFlows 2.6.0 once it's released
2 participants