Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use abspaths for the ODF plotter #182

Merged
merged 4 commits into from
Nov 21, 2024
Merged

Use abspaths for the ODF plotter #182

merged 4 commits into from
Nov 21, 2024

Conversation

mattcieslak
Copy link
Contributor

@mattcieslak mattcieslak commented Nov 20, 2024

Closes #118
@araikes noticed that the ODF plotter might be attempting to write out the pngs into the user's home directory. This PR forces the plotter to store images in the runtime working directory

@codecov-commenter
Copy link

codecov-commenter commented Nov 20, 2024

Codecov Report

Attention: Patch coverage is 8.00000% with 23 lines in your changes missing coverage. Please review.

Project coverage is 47.64%. Comparing base (e99614e) to head (4ffc278).

Files with missing lines Patch % Lines
qsirecon/cli/recon_plot.py 0.00% 12 Missing ⚠️
qsirecon/interfaces/reports.py 15.38% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
- Coverage   47.73%   47.64%   -0.10%     
==========================================
  Files          57       57              
  Lines        7213     7231      +18     
  Branches      984      986       +2     
==========================================
+ Hits         3443     3445       +2     
- Misses       3565     3581      +16     
  Partials      205      205              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds like @araikes tested this out and it works.

@tsalo
Copy link
Member

tsalo commented Nov 21, 2024

Should this close #118?

@mattcieslak
Copy link
Contributor Author

Should this close #118?

I think so

@mattcieslak mattcieslak merged commit 0b53f53 into main Nov 21, 2024
24 checks passed
@mattcieslak mattcieslak deleted the enh/robust-plot-odfs branch November 21, 2024 14:21
@mattcieslak mattcieslak restored the enh/robust-plot-odfs branch November 21, 2024 14:21
@tsalo tsalo mentioned this pull request Nov 21, 2024
@tsalo tsalo added the bug Something isn't working label Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with plot peaks crashes qsirecon
3 participants