Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump discord.py[rewrite] to latest commit hash #6124

Closed
vorpal-buildbot opened this issue Feb 26, 2019 · 6 comments
Closed

bump discord.py[rewrite] to latest commit hash #6124

vorpal-buildbot opened this issue Feb 26, 2019 · 6 comments
Labels
triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling

Comments

@vorpal-buildbot
Copy link
Contributor

Reported on Discord by silasary#0001
@triage-new-issues triage-new-issues bot added the triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling label Feb 26, 2019
silasary added a commit that referenced this issue Mar 4, 2019
@silasary
Bump rewrite version
ffd4bcb 
Fixes #6124
@bakert
Copy link
Member

bakert commented Mar 16, 2019

Latest release is Rapptz/discord.py@44a4a47 but I'm assuming we don't want that.

@bakert
Copy link
Member

bakert commented Mar 16, 2019

oh there's a PR here.

@bakert
Copy link
Member

bakert commented Mar 16, 2019

PR is failing because of ERROR: /home/travis/build/PennyDreadfulMTG/Penny-Dreadful-Tools/decksite/charts/chart.py Imports are incorrectly sorted.

Theoretically chart.py is skipped. So we're updating isort and it no longer recognizes that method of skipping?

@bakert
Copy link
Member

bakert commented Mar 16, 2019

yup, the difference is in:

-isort==4.3.10
+isort==4.3.15

somewhere.

@bakert
Copy link
Member

bakert commented Mar 16, 2019

Katelyn is on this in PyCQA/isort#885

@bakert
Copy link
Member

bakert commented Mar 16, 2019

Fixed this with 016bc80 see the isort issue.

@bakert bakert closed this as completed Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage Used by bot to label unlabeled tasks, will be removed automatically upon labeling
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bakert @vorpal-buildbot