Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix audit_mode in ldap #186

Merged
merged 1 commit into from
Feb 27, 2024
Merged

Fix audit_mode in ldap #186

merged 1 commit into from
Feb 27, 2024

Conversation

NeffIsBack
Copy link
Contributor

As pointed out in #179 there are still a few spots where audit_mode doesn't use the lib and therefore prints the "audit word" 8 times.
Now fixed:
image

@Marshall-Hallenbeck
Copy link
Collaborator

Thanks for fixing these. This is a functionality I've wanted to functionalize for a long time, we should probably create an issue to put this into a single function so we can make futures changes much more easily.

@Marshall-Hallenbeck Marshall-Hallenbeck merged commit 6454ee7 into main Feb 27, 2024
2 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the neff-audit-mode branch February 27, 2024 16:25
@NeffIsBack
Copy link
Contributor Author

Thanks for fixing these. This is a functionality I've wanted to functionalize for a long time, we should probably create an issue to put this into a single function so we can make futures changes much more easily.

What do you mean? process_secret() is a standalone function from the config stuff.

@Marshall-Hallenbeck
Copy link
Collaborator

Thanks for fixing these. This is a functionality I've wanted to functionalize for a long time, we should probably create an issue to put this into a single function so we can make futures changes much more easily.

What do you mean? process_secret() is a standalone function from the config stuff.

Turning the dozens of repeat lines of code into a function - we have code duplication in a bunch of places but this one is particularly annoying lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants