Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging fixes (double logging & function caller obfuscation) #229

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

Marshall-Hallenbeck
Copy link
Collaborator

  • do not double log output in debug mode
  • properly show calling file & lineno for such messages

Before:
image

Now:
image

Note that the success/highlight/etc are printed as DEBUG messages, but the calling file+lineno are properly being displayed for debugging purposes, instead of the logger.py file.

@Marshall-Hallenbeck Marshall-Hallenbeck added the bug-fix This Pull Request fixes a bug label Mar 27, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck self-assigned this Mar 27, 2024
@Marshall-Hallenbeck Marshall-Hallenbeck merged commit 52754f6 into main Mar 27, 2024
2 of 7 checks passed
@Marshall-Hallenbeck Marshall-Hallenbeck deleted the marshall-logging-fix branch March 27, 2024 10:35
@NeffIsBack
Copy link
Contributor

Does that also work for --verbose? Also would it be possible to log these messages as Info log level so it is more visible (and I think it matches "display" better).

@Marshall-Hallenbeck
Copy link
Collaborator Author

Honestly I think we should just get rid of --verbose and "INFO" level logging... we literally never use it. Either we want full debug mode or we want output, right? Then maybe during debug mode just display success/fail/display as "INFO"?

@NeffIsBack
Copy link
Contributor

Agreed with --verbose, but I like to have a destinction between less and more important log messages though. Maybe keep it as it doesn't hurt? But I would agree with logging the rest as info

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants