Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ldap active users bug fix #248

Merged
merged 6 commits into from
Apr 21, 2024
Merged

Conversation

termanix
Copy link
Contributor

@termanix termanix commented Apr 4, 2024

Bug fix. I got an error today when im on my client, if useraccountcontrol value is none then its crashing. Now it's checking.

image

Updated now and working again.

Change variable name.

Signed-off-by: termanix <50464194+termanix@users.noreply.github.com>
@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Apr 4, 2024
termanix added 2 commits April 4, 2024 23:31
Fixed ruff

Signed-off-by: termanix <50464194+termanix@users.noreply.github.com>
Fixed ruff spaces

Signed-off-by: termanix <50464194+termanix@users.noreply.github.com>
@Marshall-Hallenbeck
Copy link
Collaborator

Thanks for the fix. In which instances is user_account_control = None?

@termanix
Copy link
Contributor Author

termanix commented Apr 5, 2024

I encountered msExchUserAccountControl. When i research it, it's Indicates that the user is associated with the Exchange server. This property specifies the status of the Exchange account and indicates whether there is a mailbox associated with the user.
If the ms Exch User Account Control property is assigned and its value is None, it causes an error.

But i didnt get it, why it is get the msExchUserAccountControl value. If im not busy, i would have setup on local exchange server.

@mpgn mpgn added this to the v1.2.0 milestone Apr 10, 2024
Copy link
Contributor

@NeffIsBack NeffIsBack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
image

@NeffIsBack NeffIsBack merged commit 1ca2fd5 into Pennyw0rth:main Apr 21, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants