-
Notifications
You must be signed in to change notification settings - Fork 410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add file write check on smb #404
Conversation
I wonder if we still need the check on the folder if we have the file ? |
I think so since write file and create folder are two different permissions.
|
File OR Directory = WRITE |
sounds good |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM from my side
Currently NetExec only checks the "WRITE" permission on a SMB share through writing a folder.
It is also necessary to verify this permission through a file write.
This PR implements this additional check.