Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix windows and encoding stuff #446

Merged
merged 5 commits into from
Oct 12, 2024
Merged

Fix windows and encoding stuff #446

merged 5 commits into from
Oct 12, 2024

Conversation

NeffIsBack
Copy link
Contributor

This PR

Before we had wrongly encoded output and crashes in the log handler with non latin-1/cp1252 encodings:
image

This is now fixed:
image

@NeffIsBack NeffIsBack added bug-fix This Pull Request fixes a bug windows Things related specifically to running on Windows labels Oct 12, 2024
@NeffIsBack NeffIsBack linked an issue Oct 12, 2024 that may be closed by this pull request
mpgn
mpgn previously approved these changes Oct 12, 2024
@NeffIsBack
Copy link
Contributor Author

God damn it. Glad when we finally drop python 3.8...

@mpgn
Copy link
Collaborator

mpgn commented Oct 12, 2024

Do it 😉

@NeffIsBack
Copy link
Contributor Author

First things i will do after the release

@NeffIsBack
Copy link
Contributor Author

Should work like that as well, but for completeness this should be reverted when we drop 3.8 support

@NeffIsBack NeffIsBack merged commit 485f720 into main Oct 12, 2024
6 checks passed
@NeffIsBack NeffIsBack deleted the fix-windows branch October 12, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug-fix This Pull Request fixes a bug windows Things related specifically to running on Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Win) --log can't save lines containing ancient alien characters
2 participants