Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #48 tries to falsly add creds to bloodhound using --laps #49

Merged
merged 2 commits into from
Oct 4, 2023
Merged

Fix #48 tries to falsly add creds to bloodhound using --laps #49

merged 2 commits into from
Oct 4, 2023

Conversation

NeffIsBack
Copy link
Contributor

See #48

@NeffIsBack NeffIsBack added the bug-fix This Pull Request fixes a bug label Sep 27, 2023
Marshall-Hallenbeck
Marshall-Hallenbeck previously approved these changes Oct 4, 2023
View reviewed changes
Copy link
Collaborator

@Marshall-Hallenbeck Marshall-Hallenbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Marshall-Hallenbeck Marshall-Hallenbeck changed the base branch from main to develop October 4, 2023 00:18
@Marshall-Hallenbeck Marshall-Hallenbeck dismissed their stale review October 4, 2023 00:18

The base branch was changed.

@NeffIsBack NeffIsBack merged commit dec35a5 into develop Oct 4, 2023
@NeffIsBack NeffIsBack deleted the neff-bugfixes branch October 4, 2023 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Marshall-Hallenbeck Marshall-Hallenbeck Marshall-Hallenbeck approved these changes

@zblurx zblurx Awaiting requested review from zblurx

Assignees
No one assigned
Labels
bug-fix This Pull Request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NeffIsBack @Marshall-Hallenbeck