Improve bloodhound connector with Netbios domain name #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name from the domain
NeffIsBack
requested review from
zblurx,
Marshall-Hallenbeck and
mpgn
as code owners
Signed-off-by: Marshall Hallenbeck <Marshall.Hallenbeck@gmail.com>
Signed-off-by: Alex <61382599+NeffIsBack@users.noreply.github.com>
Marshall-Hallenbeck
previously approved these changes
Oct 31, 2023
There was a problem hiding this comment.
LGTM
I didn't test it but if you did it should be good @NeffIsBack
I need to set up BH in my lab env
mpgn
previously approved these changes
Nov 2, 2023
|
Adding "reviewed" label as @Marshall-Hallenbeck reviewed the code already |
mpgn
approved these changes
Nov 3, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most often the bloodhound connector can now handle it when only the netbios name of the domain is specified.
Fixes issues like #60, #78
FYI: this is branched of #35 so it is already up-to-date if this one gets merged