Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade to Go 1.11 #106

Merged
merged 2 commits into from
Dec 30, 2019
Merged

Downgrade to Go 1.11 #106

merged 2 commits into from
Dec 30, 2019

Conversation

NickyMateev
Copy link
Member

Downgrade to Go 1.11

Motivation: golang/go#35373

@NickyMateev NickyMateev self-assigned this Dec 30, 2019
KirilKabakchiev
KirilKabakchiev reviewed Dec 30, 2019
View reviewed changes
Copy link
Member

@KirilKabakchiev KirilKabakchiev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wasn't there some mandatory security issue that was fixed with 1.12 ?

@NickyMateev
Copy link
Member Author

wasn't there some mandatory security issue that was fixed with 1.12 ?

Yes, but we still decided to go this route in order to mitigate the broken pipe problem

@coveralls
Copy link

Coverage Status

Coverage remained the same at 89.88% when pulling 1504077 on decrease-go-version into 7942aea on master.

@NickyMateev NickyMateev merged commit c3bb9ba into master Dec 30, 2019
@NickyMateev NickyMateev deleted the decrease-go-version branch December 30, 2019 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KirilKabakchiev KirilKabakchiev KirilKabakchiev approved these changes

@pankrator pankrator pankrator approved these changes

@dzahariev dzahariev Awaiting requested review from dzahariev

@dotchev dotchev Awaiting requested review from dotchev

Assignees

@NickyMateev NickyMateev

Labels
👋request review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@NickyMateev @coveralls @pankrator @KirilKabakchiev