Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PER-9718 [back-end] Endpoint for admins to create environment configu… #137

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

iulianvsp
Copy link
Contributor

…ration

New endpoint to create a feature-flag. There are validations on the name and description + the name of the flag has to be unique.

Unit and functional tests are covering all scenarios

packages/api/src/feature_flag/service/create.ts Outdated Show resolved Hide resolved
packages/api/src/feature_flag/service/create.ts Outdated Show resolved Hide resolved
packages/api/src/feature_flag/validators.ts Outdated Show resolved Hide resolved
packages/api/src/feature_flag/service/create.test.ts Outdated Show resolved Hide resolved
New endpoint feature-flags that will return a list of globally enabled flag names if the user is not authenticated or a regular user and all feature flags if the user is an administrator

Functional testing was added for both scenarios
@iulianvsp iulianvsp force-pushed the PER-9718 branch 3 times, most recently from d587711 to c742a0a Compare October 23, 2024 13:25
@iulianvsp iulianvsp changed the base branch from PER-9717 to main October 24, 2024 10:40
@iulianvsp iulianvsp marked this pull request as ready for review October 24, 2024 10:40
Copy link
Member

@liam-lloyd liam-lloyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but do delete the unused SQL file before merging.

packages/api/src/feature_flag/queries/get_feature_flag.sql Outdated Show resolved Hide resolved
…ration

New endpoint to create a feature-flag. There are validations on the name and description + the name of the flag has to be unique.

Unit and functional tests are covering all scenarios
@iulianvsp iulianvsp merged commit d78b2b5 into main Oct 25, 2024
2 checks passed
@iulianvsp iulianvsp deleted the PER-9718 branch October 25, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants